Fix SGEMM returning wrong results in multithreading on NeoverseV2#5643
Open
martin-frbg wants to merge 1 commit intoOpenMathLib:developfrom
Open
Fix SGEMM returning wrong results in multithreading on NeoverseV2#5643martin-frbg wants to merge 1 commit intoOpenMathLib:developfrom
martin-frbg wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
Contributor
|
Is this ready to go? |
Collaborator
Author
|
It definitely fixes the problem on NeoverseV2, but (a) there may be other arm64 cpus similarly affected and (b) I haven't fully understood the underlying issue with that specific parameter that was introduced fairly recently - it may be papering over a missing tail call in the gemm kernel it rode in on, or something else entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes numpy/numpy#30816